Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim-utils: restore beforePlugins option #87127

Merged
merged 1 commit into from May 6, 2020
Merged

vim-utils: restore beforePlugins option #87127

merged 1 commit into from May 6, 2020

Conversation

arizonahanson
Copy link

some plugins require configuration before the plugin definition

Motivation for this change

my vim setup was broken when the beforePlugins option was removed, which allowed me to configure plugins that needed variables set before the plugin is loaded, like ALE.

Things done

restored the buildPlugins option, and put it to use in the rc file before the plugin definitions. tested that this worked on my system by building with nixos-rebuild switch -I nixpkgs=...

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

vim-utils: restore beforePlugins option
be1594b 
some plugins require configuration before their plugin definition
@arizonahanson arizonahanson mentioned this pull request May 6, 2020
Closed
@jonringer jonringer requested review from evanjs and timokau May 6, 2020 22:29
@timokau timokau merged commit a12092b into NixOS:master May 6, 2020
@arizonahanson arizonahanson deleted the fix/vim-beforePlugins branch May 7, 2020 00:34
@jonringer
Copy link
Contributor

Congrats @isaacwhanson on your first nixpkgs PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@jonringer jonringer jonringer approved these changes

@evanjs evanjs Awaiting requested review from evanjs

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arizonahanson @jonringer @bjornfor @timokau @Janik-Haag