nottetris2: init at 2.0 #87028
nottetris2: init at 2.0 #87028
Conversation
|
The homepage does not state an explicit version, nor a specific license. I've used the same as in https://github.com/NixOS/nixpkgs/blob/master/pkgs/games/rimshot/default.nix which is from the same developers. |
|
Turns out the source is actually also on GitHub with a proper version and license… https://github.com/Stabyourself/nottetris2/releases |
Sohalt
force-pushed
the
nottetris2
branch
2 times, most recently
from
17f98d9
to
1c9c081
Compare
|
Please squash down to one commit. |
done |
|
|
||
| meta = with stdenv.lib; { | ||
| description = "It's like Tetris, but it's not"; | ||
| platforms = platforms.linux; |
There was a problem hiding this comment.
are we allowed to platforms = love_0_7.meta.platforms;?
There was a problem hiding this comment.
Right now love_0_7.meta.platforms is stenv.lib.platforms.linux, so it would definitely work. It should most probably also work on darwin, should love2d get support for that, but I cannot test that.
Co-authored-by: Yorick <yorickvanpelt@gmail.com>
|
@GrahamcOfBorg build nottetris2 |
|
|
||
| src = fetchFromGitHub { | ||
| owner = "Stabyourself"; | ||
| repo = pname; |
There was a problem hiding this comment.
Would it be possible to fetchurl from https://stabyourself.net/nottetris2/ instead? The website appears to be by far more reachable on the internet than the github when searching for nottetris2, and I can't find a link from the website to the github — the github being identity theft, while unlikely, is unfortunately always a possibility. This being said, I notice that orthorobot already uses the github, so… it's probably not that bad to add one dependency on this github here, but I wonder where the “authority” was taken from when merging orthorobot :)
There was a problem hiding this comment.
The download on the website isn't versioned and doesn't contain a license, so I'd be in favor of sticking with GitHub.
We can also do the direct approach: @Stabyourself you're one of the people responsible for stabyourself.net, right? Can you maybe include a link there to your GitHub or clarify the situation?
There was a problem hiding this comment.
Hi, yeah I'm the dev of the games. Back then I didn't really know/care much about open source standards, so everything's a bit home-baked, sorry about that.
I changed all the "Source" links on the website to go to github instead.
There was a problem hiding this comment.
Great, thank you! 💯
Merging, as a consequence :)
Motivation for this change
I want to play this game
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)