Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire-desktop: linux 3.17.2924 -> 3.18.2925, mac 3.17.3666 -> 3.18.3728 #86994

Merged
merged 2 commits into from Jun 6, 2020
Merged

wire-desktop: linux 3.17.2924 -> 3.18.2925, mac 3.17.3666 -> 3.18.3728 #86994

merged 2 commits into from Jun 6, 2020

Conversation

toonn
Copy link
Contributor

@toonn toonn commented May 5, 2020

(cherry picked from commit 84b5107)

Motivation for this change

Backport of #86991

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from worldofpeace May 5, 2020 20:58
@arianvp arianvp self-requested a review May 5, 2020 21:07
@toonn
Copy link
Contributor Author

toonn commented May 6, 2020

Mac release happened so I bumped and tested version 3.17.3666.

@toonn toonn changed the title wire-desktop: linux 3.16.2923 -> 3.17.2924 wire-desktop: linux 3.17.2924 -> 3.18.2925, mac 3.17.3666 -> 3.18.3728 Jun 2, 2020
@toonn
Copy link
Contributor Author

toonn commented Jun 2, 2020 •
edited

Superseded by new versions.
Now a backport of #89369

@flokli flokli merged commit 0a11634 into NixOS:release-19.09 Jun 6, 2020
@flokli
Copy link
Contributor

flokli commented Jun 6, 2020

Note support for 19.09 has ended, so there's not really a need to bump these anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arianvp arianvp arianvp approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toonn @flokli @arianvp