Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire-desktop: linux 3.16.2923 -> 3.17.2924 #86991

Merged
merged 2 commits into from May 25, 2020
Merged

wire-desktop: linux 3.16.2923 -> 3.17.2924 #86991

merged 2 commits into from May 25, 2020

Conversation

toonn
Copy link
Contributor

@toonn toonn commented May 5, 2020

Motivation for this change

Bump wire-dekstop version, I expect a release for darwin soon.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced May 5, 2020
Merged
Merged
@ofborg ofborg bot requested review from worldofpeace, Kiwi and arianvp May 5, 2020 20:48
@toonn
Copy link
Contributor Author

toonn commented May 6, 2020

Mac release happened so I bumped and tested version 3.17.3666.

@ofborg ofborg bot requested a review from arianvp May 6, 2020 14:06
@wmertens wmertens merged commit cedace7 into NixOS:master May 25, 2020
@wmertens
Copy link
Contributor

Don't know what it is but LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

@arianvp arianvp arianvp approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@Kiwi Kiwi Awaiting requested review from Kiwi

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toonn @wmertens @arianvp