Fix ottd_display_speed to reflect changes done in OpenTTD #75
Conversation
planetmaker
force-pushed
the
speed_fixes
branch
from
adea28a
to
5bc8f9d
Compare
nml/actions/action0properties.py
Outdated
| @@ -255,7 +255,7 @@ def cargo_list(value, max_num_cargos): | |||
| } | |||
|
|
|||
| def ottd_display_speed(value, divisor, unit): | |||
| return int(value.value / divisor) * 10 // 16 * unit.ottd_mul >> unit.ottd_shift | |||
| return (round(value.value // divisor * 10 * unit.ottd_mul) >> unit.ottd_shift) // 16 | |||
There was a problem hiding this comment.
Why is there an integer division "// divisor" inside a round? That looks wrong to me.
There was a problem hiding this comment.
I think this function is meant to replicate the exact behaviour of OTTD's ConvertKmhishSpeedToDisplaySpeed.
Thus I would expect:
(round(value.value / divisor * 10 * unit.ottd_mul) >> unit.ottd_shift) // 16
There was a problem hiding this comment.
I was actually wondering whether we may have a round there at all... or whether we get some platform dependency there which we might not want.
Though without an integer being left of the shift operator, we get a type error... but then with float math we can skip using the shift operator and do float math all the way; the original #35 simply does not work at all.
This is a rebased version of #35
Closes #35