Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mari0: init at 1.6.2 #87034

Merged
merged 3 commits into from May 7, 2020
Merged

mari0: init at 1.6.2 #87034

merged 3 commits into from May 7, 2020

Conversation

Sohalt
Copy link
Contributor

@Sohalt Sohalt commented May 6, 2020

Motivation for this change

I want to play the game.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ryantm
ryantm requested changes May 7, 2020
View reviewed changes
pkgs/games/mari0/default.nix Show resolved Hide resolved
pkgs/games/mari0/default.nix Outdated Show resolved Hide resolved
pkgs/games/mari0/default.nix Outdated Show resolved Hide resolved
Sohalt and others added 2 commits May 7, 2020 21:08
@Sohalt @ryantm
Quote URL per RFC 45, use SSL
aa1e4e1 
Co-authored-by: Ryan Mulligan <ryan@ryantm.com>
@Sohalt @ryantm
Inherit pname and version instead of setting name explicitly
ed5943c 
Co-authored-by: Ryan Mulligan <ryan@ryantm.com>
@Sohalt Sohalt requested a review from ryantm May 7, 2020 19:42
@ryantm
Copy link
Member

ryantm commented May 7, 2020

Result of nixpkgs-review pr 87034 1

1 package built:
- mari0

@ryantm ryantm merged commit 64bed7d into NixOS:master May 7, 2020
@Sohalt Sohalt deleted the mari0 branch May 7, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sohalt @ryantm