Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robo3t: Remove unrecognized category from desktop item #87093

Merged
merged 1 commit into from May 7, 2020

Conversation

baracoder
Copy link
Contributor

Motivation for this change

"Development;IDE;mongodb;" for key "Categories" in group "Desktop Entry" contains an unregistered value "mongodb"; values extending the format should start with "X-"
builder for '/nix/store/8apqkxdir4ndyqm1mw36v5zsxarkrl5f-robo3t.desktop.drv' failed with exit code 1

Entry in keywords is also not required in this case

A list of strings which may be used in addition to other metadata to describe this entry. This can be useful e.g. to facilitate searching through entries. The values are not meant for display, and should not be redundant with the values of Name or GenericName.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@emanueleperuffo emanueleperuffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ryantm ryantm merged commit c8653d5 into NixOS:master May 7, 2020
@baracoder baracoder deleted the robo3t-desktop branch May 7, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants