nixosTests.ldap: remove #87004
nixosTests.ldap: remove #87004
Conversation
flokli
changed the title
|
As per #86305 (comment), the module works pretty well for basic usage, though maybe (I've never administered a complex LDAP server) it isn't adapted to complex use cases. So IMO if we just deprecate/remove this without proposing anything better, we then lose the “simple” use case just working, and don't get the complex use cases working any better. I'm not sure what this would thus bring, though I totally understand that with the information available before my comment there it was the only reasonable thing to do :) |
|
As per #86305 (comment), if there's a more simpler way to test basic functionality, such a VM test would help to verify (some) things are still working. Would you be willing to add a simple VM test on top? |
|
I can add a basic test based on my server: https://github.com/Mic92/dotfiles/blob/master/nixos/eve/modules/openldap.nix#L14 |
|
@Mic92 thanks! In that case, feel free to ping me on the PR :-) |
This seems to have worked in 15f105d (5 months ago) but broke somewhere in the meantime. The current module doesn't seem to be underdocumented and might need a serious refactor. It requires quite some hacks to get it to work (see NixOS#86305 (comment)), or how the ldap.nix test used systemd.services.openldap.preStart and made quite some assumptions on internals. Mic92 agreed on being added as a maintainer for the module, as he uses it a lot and can possibly fix eventual breakages. For the most basic startup breakages, the remaining openldap.nix test might suffice.
flokli
force-pushed
the
nixos-tests-remove-ldap
branch
from
93aaf9a
to
450f8a4
Compare
flokli
changed the title
|
@Mic92 I pushed a new commit that only removes the broken VM tests, and adds you as a maintainer to the |
Motivation for this change
This tests seem to have worked in 15f105d, but
broke somewhere in the meantime.
The current module doesn't seem to be generally usable and might need a
serious refactor. It requires quite some hacks to get it to work (see
#86305 (comment)),
or how the test used systemd.services.openldap.preStart and made quite
some assumptions on internals.
On top of that, the test has been broken since 2020-01-12 (5 months), so
there's no guarantee this works at all.
Let's drop the test and throw a big deprecation warning to alert
everyone still using the module, and if nobody speaks up, remove it as well.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)