Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apt-cacher-ng: 3.2 → 3.5 #87119

Merged
merged 1 commit into from May 7, 2020
Merged

apt-cacher-ng: 3.2 → 3.5 #87119

merged 1 commit into from May 7, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented May 6, 2020

Motivation for this change

Fixes: CVE-2017-7443, CVE-2020-5202

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt mentioned this pull request May 6, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from makefu May 6, 2020 17:43
makefu
makefu approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with config:
ForeGround: 1
CacheDir: /tmp
LogDir: /tmp
PidFile: /tmp/apt-cacher-ng.pid
ExTreshold: 90000
CAfile: /etc/ssl/certs/ca-bundle.crt

Port: 9800
BindAddress: 127.0.0.1

defaults:

Remap-debrep: file:deb_mirror*.gz /debian ; file:backends_debian
Remap-uburep: file:ubuntu_mirrors /ubuntu ; file:backends_ubuntu
Remap-debvol: file:debvol_mirror*.gz /debian-volatile ; file:backends_debvol
Remap-cygwin: file:cygwin_mirrors /cygwin
Remap-sfnet: file:sfnet_mirrors
Remap-alxrep: file:archlx_mirrors /archlinux
Remap-fedora: file:fedora_mirrors
Remap-epel: file:epel_mirrors
Remap-slrep: file:sl_mirrors # Scientific Linux
Remap-gentoo: file:gentoo_mirrors.gz /gentoo ; file:backends_gentoo

ReportPage: acng-report.html
SupportDir: /nix/store/8rg177n6h3hsgh9ni2c5a40kmccibmd9-apt-cacher-ng-3.5/lib/apt-cacher-ng
LocalDirs: acng-doc /nix/store/8rg177n6h3hsgh9ni2c5a40kmccibmd9-apt-cacher-ng-3.5/share/doc/apt-cacher-ng


boots up, everything seems to work

@ryantm ryantm merged commit 3684d66 into NixOS:master May 7, 2020
@mweinelt mweinelt deleted the pr/apt-cacher-ng branch May 7, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@makefu makefu makefu approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @ryantm @makefu