Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopass: Adapt to buildGoModule output naming scheme #86977

Merged
merged 1 commit into from May 6, 2020

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Turns out there's another rebase artifact in #85521 - since switch to buildGoModule $bin output does not exist anymore, use $out instead

cc @andir

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build gopass

@marsam marsam merged commit b290ef6 into NixOS:master May 6, 2020
@rvolosatovs rvolosatovs deleted the fix/gopass-alias branch May 6, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants