"Not you: team." (Rework README) #482
Merged
+156
−528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
force-pushed
the
not-you-team
branch
4 times, most recently
from
80b12e2 to
0b18420
Compare
Co-Authored-By: Cole Helbling <cole.e.helbling@outlook.com>
Some of the information in the README is outdated, such as the sections
detailing the privileges of known users (everybody is now a known user).
The only distinction made is between that of trusted users and everybody
else. Trusted users gain an additional host to run builds and tests on:
x86_64-darwin. Everybody else is locked to x86_64-linux and
aarch64-linux.
With the removal of all mentions of "known users", the
`config.{extra-,}known-users.json` files have also been removed. This
change will require coordination with the infrastructure repo [1] --
namely, a PR removing references to these files (otherwise, I imagine,
deploys will fail).
Something Graham has mentioned a few times is how he wants to decouple
ofborg from his persona. Thus, `@ofborg` is now used in place of
`@GrahamcOfBorg` everywhere possible (it is still possible to use
`@GrahamcOfBorg`, so it has not been removed from the codebase at this
time).
[1] https://github.com/ofborg/infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the information in the README is outdated, such as the sections
detailing the privileges of known users (everybody is now a known user).
The only distinction made is between that of trusted users and everybody
else. Trusted users gain an additional host to run builds and tests on:
x86_64-darwin. Everybody else is locked to x86_64-linux and
aarch64-linux.
With the removal of all mentions of "known users", the
config.{extra-,}known-users.jsonfiles have also been removed. Thischange will require coordination with the infrastructure repo [1] --
namely, a PR removing references to these files (otherwise, I imagine,
deploys will fail).
Something Graham has mentioned a few times is how he wants to decouple
ofborg from his persona. Thus,
@ofborgis now used in place of@GrahamcOfBorgeverywhere possible (it is still possible to use@GrahamcOfBorg, so it has not been removed from the codebase at thistime).
[1] https://github.com/ofborg/infrastructure
Thanks to @sorki, there is now a
Hackingsection that details aquick-and-dirty way to get started with working on ofborg's internals.
Depends on ofborg/infrastructure#21.
Closes #445.
EDIT: I've removed the "Running a Build" section from the README and placed its contents in the Wiki: https://github.com/NixOS/ofborg/wiki/Operating-a-Builder/