nixos/network-interfaces-scripted: fix dhcpcd when mac address set #87116
Conversation
- Fixes issue NixOS#74471 (dhcpcd is started before mac addresses are set)
There was a problem hiding this comment.
eeeh… This is trying to mask a problem which we wouldn't have if we'd apply interface parameters as soon as the interfaces appear, via udev. Even if we'd merge this PR as-is and add this dependency, things could still fail during reconfiguration.
I made the scripts below scripted-networking only in #85170, as running these scripts for networkd definitely was wrong, and I was too lazy to think about how to make scripted networking better, as I mostly use the networkd codepaths,
However, mac address and MTU should be perfectly fine configurable via a systemd.network.links directive even in the non-networkd case (as it's handled by udev, not networkd) since #82941.
The only line in the script that would need to be left would be the line bringing up the interface.
|
Thanks, I was finally able to try your suggested work-around but it did not work for me. Possibly because I'm working on a bridge that may not yet exist when systemd wants to set its MAC address. I should probably attempt a pure |
|
Hm - the systemd.link files should trigger every time a new device appears, and not just on a specific point in time - so it should be way more robust. I'll send a PR shortly that will make use of this for scripted networking as well, feedback appreciated. |
|
@goertzenator PR is at #88032. |
…MTUBytes
The `network-link-${i.name}` units raced with other things trying to
configure the interface, or ran before the interface was available.
Instead of running our own set of shell scripts on boot, and hoping
they're executed at the right time, we can make use of udev to configure
the interface *while they appear*, by providing `.link` files in
/etc/systemd/network/*.link to set MACAddress and MTUBytes.
This doesn't require networkd to be enabled, and is populated properly
on non-networkd systems since
NixOS#82941.
This continues clean-up work done in
NixOS#85170 for the scripted networking
stack.
The only leftover part of the `network-link-${i.name}` unit (bringing
the interface up) is moved to the beginning of the
`network-addresses-${i.name}` unit.
Fixes: NixOS#74471
Closes: NixOS#87116
Fixes issue #74471 (dhcpcd is started before mac addresses are set)
Motivation for this change
I want my NixOS system to boot up with working networking.
Things done
I ran this patch against my installation at
20.03and it corrected the issue. I attempted to verify againstmasterbut gave up after several hours of building.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)