Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/shells-environment: Add environment.homeLocalBinInPath #87058

Closed
wants to merge 1 commit into from
Closed

nixos/shells-environment: Add environment.homeLocalBinInPath #87058

wants to merge 1 commit into from

Conversation

DamienCassou
Copy link
Contributor

@DamienCassou DamienCassou commented May 6, 2020 •
edited

Motivation for this change

~/.local/bin is a common place to put arbitrary user scripts that's replacing the old ~/bin. This commit makes it easy to add that directory to the user's PATH.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@DamienCassou DamienCassou requested review from chkno and andir May 6, 2020 06:46
andir
andir reviewed May 6, 2020
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add this. If this is really needed you can just put that in your extraInit. We just kept the other flag since it had been the default for "forever".

chkno
chkno suggested changes May 7, 2020
View reviewed changes
Copy link
Member

@chkno chkno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @andir; this is not needed. In fact, since homeBinInPath's default was flipped to false in #72584 and since adding ~/bin/ to PATH via extraInit is so straightforward, I think it makes sense to deprecate and remove homeBinInPath eventually. (I'm sympathetic to edolstra's comment in #72584 about this being unnecessary churn, so I'm not in a hurry for this, but I think we should be moving in the direction of fewer of these add-to-PATH options rather than adding more.)

@DamienCassou
Copy link
Contributor Author

Thank you for your quick review and piece of advice. I'm closing this.

@DamienCassou DamienCassou deleted the damien/homeLocalBinInPath branch May 7, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir left review comments

@chkno chkno chkno requested changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DamienCassou @andir @chkno