Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] apt-cacher-ng: 3.2 → 3.5 #87122

Merged
merged 1 commit into from May 7, 2020
Merged

[20.03] apt-cacher-ng: 3.2 → 3.5 #87122

merged 1 commit into from May 7, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented May 6, 2020

Motivation for this change

Backport of #87119

Fixes: CVE-2017-7443, CVE-2020-5202
(cherry picked from commit 1c7ad58)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
apt-cacher-ng: 3.2 → 3.5
3729fae 
Fixes: CVE-2017-7443, CVE-2020-5202
(cherry picked from commit 1c7ad58)
@mweinelt mweinelt changed the title apt-cacher-ng: 3.2 → 3.5 [20.03] apt-cacher-ng: 3.2 → 3.5 May 6, 2020
@ofborg ofborg bot requested a review from makefu May 6, 2020 17:56
makefu
makefu approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, same results as #87119 with nix-review

@ryantm ryantm merged commit 52e9f62 into NixOS:release-20.03 May 7, 2020
@mweinelt mweinelt deleted the 20.03/pr/apt-cacher-ng branch May 7, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@makefu makefu makefu approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @ryantm @makefu