Skip to content

terragrunt: 0.23.2 -> 0.23.14 #87089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2020
Merged

terragrunt: 0.23.2 -> 0.23.14 #87089

merged 1 commit into from
May 7, 2020
+9 −537

Conversation

06kellyjac
Copy link
Member

Moved to use go modules build

This is my first real PR to nixpkgs, I welcome any and all criticism.
I removed the rm vendor line because it doesn't look relevant for go mod builds(?)

Let me know if there are extra steps I need to take

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested review from peterhoeg and kalbasit May 6, 2020 12:27
@ryantm
Copy link
Member

ryantm commented May 7, 2020

Thanks for your first PR welcome.

Looks like you can delete the deps.nix file too.

ryantm
ryantm requested changes May 7, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove deps.nix file

@06kellyjac
Copy link
Member Author

Ah of course, I'll get on that

@06kellyjac
terragrunt: 0.23.2 -> 0.23.14
fc1b52c 
Moved to use go modules build
Deleted old deps.nix file used with dep
jonringer
jonringer approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 87089 1

1 package built: - terragrunt

@jonringer jonringer merged commit cef39f9 into NixOS:master May 7, 2020
@06kellyjac 06kellyjac deleted the terragrunt branch August 10, 2020 08:21
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm

@jonringer jonringer

@peterhoeg peterhoeg

@kalbasit kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@06kellyjac @ryantm @jonringer @Janik-Haag