Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Themix GUI theme designer (a.k.a. Oomox) packages #87054

Closed
wants to merge 19 commits into from
Closed

Add Themix GUI theme designer (a.k.a. Oomox) packages #87054

wants to merge 19 commits into from
+369 −0

Conversation

mnacamura
Copy link
Contributor

@mnacamura mnacamura commented May 6, 2020 •
edited
Loading

Motivation for this change

Themix GUI theme desiner (Oomox) is a great tool for customizing desktop themes and console color palettes. It's packaged in a number of distros: Arch, Debian, Ubuntu, CentOS, Fedora, etc. Why not in Nixpkgs?AUR and COPR have it. deb package is provided by the Themix project.

Themix has a number of plugins but I would like to keep this PL minimal: It ships only import-image, theme-oomox, and icons-papirus plugins.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 6, 2020
@mnacamura
Copy link
Contributor Author

Upstream version bump. I’ll update this PL later.

@mnacamura mnacamura marked this pull request as draft June 18, 2020 04:50
@jacobdillon
Copy link
Contributor

Any update on this?

@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@mnacamura
Copy link
Contributor Author

I'm preparing an experimental overlay for the Themix project here. I'd like to update this PL after ensuring the stability of packages in the overlay. Anyone interested in testing are welcome.

SuperSandro2000
SuperSandro2000 reviewed Apr 27, 2021
View reviewed changes
mnacamura and others added 12 commits April 28, 2021 19:10
@mnacamura
themix-gui: init at 1.13.2.1

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mweinelt Martin Weinelt
GPG key ID: BD4AA0528F63F17E
Expired
Verified
Learn about vigilant mode
b7097ea
@mnacamura
themix-import-images: init at 1.13.2.1

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8c6799b
@mnacamura
themix-theme-oomox: init at 1.12
216ae12
@mnacamura
themix-icons-papirus: init at 1.13.2.1
53927c1
@mnacamura
themix-theme-oomox: use 'makefile' variable
ac69bad
@mnacamura @SuperSandro2000
Apply suggestions from code review
7e77a54 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@mnacamura @SuperSandro2000
Apply suggestions from code review
b37b540 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@mnacamura
themix-{gui,theme-oomox}: fix license
ba0f0b1
@mnacamura
themix-gui: add missing dependency to lib
0dbe4c9
@mnacamura
themix-theme-oomox: 1.12 -> 1.12.r2.g0db28619
a798d35
@mnacamura
themix-gui: 1.13.2.1 -> 1.13.3
962b4c1
@mnacamura
themix-import-images: enable python packages
383ceb0
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 28, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 labels Apr 28, 2021
@mnacamura mnacamura marked this pull request as ready for review April 28, 2021 11:53
SuperSandro2000
SuperSandro2000 reviewed Apr 30, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the python packages:

  • Missing pythonImportsCheck and checkPhase
  • platforms should be set if it is unix because that is the default set by buildPythonPackage.

pkgs/applications/misc/themix/theme-oomox/default.nix
src = fetchFromGitHub {
owner = "themix-project";
repo = "oomox-gtk-theme";
rev = "e0d729510791b4797e80610b73b5beea07673b10";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not fetching https://github.com/themix-project/oomox-gtk-theme/releases/tag/1.12?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because version 1.12.r2 has some bug fixes for gtk3.20+.

pkgs/applications/misc/themix/import-images/default.nix Outdated
Comment on lines 2 to 4
, enableColorthief ? true
, enableColorz ? true
, enableHaishoku ? true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would anyone want to disable these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Removed these options.

@mnacamura
Copy link
Contributor Author 

* platforms should be set if it is unix because that is the default set by buildPythonPackage.

Do you mean "if it is not unix"?

@stale
Copy link

stale bot commented Oct 30, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2021
@quantenzitrone
Copy link
Contributor

why is this pr dead? i would really like to have themix on nixos

@SuperSandro2000
Copy link
Member

I don't know but it is for at least a year, so closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

@FRidh FRidh

@jonringer jonringer

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mnacamura @jacobdillon @quantenzitrone @SuperSandro2000 @ryantm