python3Packages.spyder_3: remove broken application #87062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this had makeDesktopItem defined in it. Some recent tests enabled for this option made it fail. It's no longer used as an application (see the main spyder attribute for that), so all application aspects have been removed.
|
Why shouldn't this be possible to use as application as well? |
|
@FRidh I didn't think anyone would use this v3.3.6 over the v4.1.2 we currently have in nixpkgs. But if anyone would like to use it I'm happy to add it in. Do you want it added? |
|
OK, I see that 4 works now as well (#83038). Why should it remain as library then? Edit: Nevermind, I see for cq-editor. |
|
Yeah, just cq-editor. I actually tried to modify the cq-editor code to work with spyder v4, but that task was too difficult for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
python3Packages.spyder_3was failing due to incorrectly defined desktop item:https://hydra.nixos.org/build/117762361
Things done
python3Packages.spyder_3should only be used as a library (python3Packages.spydergets made into an application), so I removed all the application stuff from it. This reduced closure size and fixed the build.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Also tested
cq-editor, which is the only attribute that usesspyder_3, and it works fine.I should probably backport this to 20.03 as well.