Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "PHP maintainer team" #86341

Merged
merged 1 commit into from Apr 29, 2020
Merged

Revert "PHP maintainer team" #86341

merged 1 commit into from Apr 29, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Apr 29, 2020

Reverts #85575

@etu etu requested a review from edolstra as a code owner April 29, 2020 17:56
@etu etu merged commit 3407b8c into master Apr 29, 2020
@etu etu deleted the revert-85575-php-maintainer-team branch April 29, 2020 17:57
@FRidh
Copy link
Member

FRidh commented May 1, 2020

Why? Please motivate in commit message.

@etu
Copy link
Contributor Author

etu commented May 1, 2020

I was planning to merge #85026 before #85575 and then had a email asking "why isn't this merged yet" and I thought "yes, I was planning to merge that by now".

So I merged #85575 before #85026 which created huge conflicts in #85026.

So I reverted #85575, merged #85026, rebased and resolved the conflicts and created/merged #86342 to introduce the maintainer team.

@asymmetric
Copy link
Contributor

Can we please refrain from merging our own unreviewed PRs in the future?

@etu
Copy link
Contributor Author

etu commented Jun 26, 2020

Sure, but it was blocking me from doing actually useful things that I sensed was way more critical to get in. If you feel that a revert commit of metadata is something that later was going to be re-added is bad I'll be more careful in the future.

And there's a decent explanation in the comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants