Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monotone: openssl in botan is not needed, so drop to avoid old openssl #86320

Merged
merged 1 commit into from Apr 29, 2020
Merged

monotone: openssl in botan is not needed, so drop to avoid old openssl #86320

merged 1 commit into from Apr 29, 2020
+1 −0

Conversation

7c6f434c
Copy link
Member

Motivation for this change

OpenSSL used currently by Botan1 is vulnerable, and it is not needed for Monotone.

Trivial fix, almost leaf package, I have tested things work. Will self-merge once checks pass.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 29, 2020
@Mic92
Copy link
Member

Mic92 commented Apr 29, 2020

Please port to stable.

@7c6f434c 7c6f434c merged commit 02218dd into NixOS:master Apr 29, 2020
This was referenced Apr 29, 2020
Merged
Merged
@7c6f434c
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@7c6f434c @Mic92