ventoy: init at 1.0.07 #86382
ventoy: init at 1.0.07 #86382
Conversation
| installPhase = '' | ||
| cp -r . $out | ||
| mkdir -p $out/bin | ||
| makeWrapper $out/Ventoy2Disk.sh $out/bin/ventoy |
There was a problem hiding this comment.
| makeWrapper $out/Ventoy2Disk.sh $out/bin/ventoy | |
| ln -s $out/Ventoy2Disk.sh $out/bin/ventoy |
| sha256 = "13raplng4bls84yfcami69wm7wb53rmv8ml9w8974ssxvidy31vc"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ makeWrapper ]; |
|
Can you investigate building from source ? |
|
Some dependencies are not hardcoded:
So you actually need the wrapper :) Try running it in an empty path: |
|
@symphorien Waiting for upstream to provide instructions on building from source. OK, I will go through the script and add all the dependencies via |
|
@filalex77 @symphorien The building from source instructions have been provided by upstream here: https://github.com/ventoy/Ventoy/blob/master/DOC/BuildVentoyFromSource.txt. It will be difficult to do so as there are a lot of specific parts necessary for the compilation. And there are many hardcoded paths in the various install scripts. I ran I am not too familiar with nixpkgs convention on binary packages, but I think it would be much more efficient to use the binary release provided by ventoy. If source code is really preferred, it would take a while to work through all the needed substitutions in the install scripts and other problems that might be encountered. |
| { stdenv, fetchurl, makeWrapper }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "ventoy"; |
There was a problem hiding this comment.
| name = "ventoy"; | |
| pname = "ventoy"; |
| nativeBuildInputs = [ makeWrapper ]; | ||
|
|
||
| installPhase = '' | ||
| cp -r . $out |
There was a problem hiding this comment.
| cp -r . $out | |
| mkdir -p $out/share/ventoy $out/bin | |
| cp -r . $out/share/ventoy |
This will prevent populating the nix profile with ventoy data files
|
ping |
|
@Br1ght0ne please address the review feedback. |
|
Closing because author did not respond in the last months. Feel free to reopen the discussion. |
|
I might submit a PR for this package later then, I have something kind of ready. |
|
I'd still be interested in this. @Pacman99 does your version work? |
|
I think my method just used autopatchelf on the binaries to get them to run on nixos. But I can't seem to find the code anymore. After I got a pinephone with thumbdrives, I didn't have much use for ventoy anymore. I looked at the compiling document and it doesn't seem that hard to replicate in a nix derivation. From what I remember though, ventoy code has to be included in the usb drive that you use it on and I'm not sure how that would work with ventoy residing in a nix derivation. I don't have any motivation to prepare a PR for it myself, but if you get around to it, feel free to ping me I'd love to help, ventoy is a really cool piece of software. |
Motivation for this change
Ventoy is a tool for creating bootable USBs that allow selecting from ISO files on the drive.
Seems to have no dependencies, and works great for me.
Latest stable release: https://github.com/ventoy/Ventoy/releases/tag/v1.0.07
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)