Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmux: 3.1 -> 3.1a #86351

Merged
merged 1 commit into from Apr 30, 2020
Merged

tmux: 3.1 -> 3.1a #86351

merged 1 commit into from Apr 30, 2020

Conversation

matthiasbeyer
Copy link
Contributor

From the changelog:

* Do not close stdout prematurely in control mode since it is needed to print
  exit messages. Prevents hanging when detaching with iTerm2.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthiasbeyer
tmux: 3.1 -> 3.1a
d6bcacc 
From the changelog:

    * Do not close stdout prematurely in control mode since it is needed to print
      exit messages. Prevents hanging when detaching with iTerm2.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@ofborg ofborg bot requested a review from fpletz April 29, 2020 20:20
@Mic92
Copy link
Member

Mic92 commented Apr 29, 2020

Result of nixpkgs-review pr 86351 1

1 package blacklisted:
- tests.nixos-functions.nixos-test
4 packages built:
- byobu
- overmind
- tmux
- tmux-cssh

@mweinelt mweinelt mentioned this pull request Apr 29, 2020
Closed
10 tasks
@marsam marsam merged commit 75c39e0 into NixOS:master Apr 30, 2020
@matthiasbeyer matthiasbeyer deleted the update-tmux branch April 30, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @Mic92 @marsam