fish: make python an optional dependency #86316
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
Apr 29, 2020
|
@ofborg eval Also, let's get an eval going... |
cole-h
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
Diff LGTM. Overall in favor of this change. fish_config with Python disabled fails, as expected.
EDIT: Closure goes from 190.3M to 125.5M with Python disabled, according to nix path-info -Sh ./result.
[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/86316
1 package built:
fish
@ofborg build fish
ryantm
added
2.status: merge conflict
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
ofborg
bot
removed
the
2.status: merge conflict
fricklerhandwerk
approved these changes
May 9, 2021
Python is still used for tests, but does not become part of the closure. In addition, nowadays fish only ever uses Python via __fish_anypython, so using sed or propagating python isn't necessary anymore.
fricklerhandwerk
approved these changes
May 10, 2021
cole-h
approved these changes
May 10, 2021
|
Thanks again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fish needs Python only for generating completions from man pages and the web config editor, so people may want to avoid depending on it. Even without depending on Python, the functions can still be called by adding Python to
$PATH(using e.g.nix-shell). The package still depends on Python by default.Notes
These days fish only uses the
__fish_anypthonfunction to find an interpreter to use, so using sed or propagating python isn't necessary anymore.cc @adisbladis
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)