Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: 0.108.7 -> 0.109.0 #86326

Merged
merged 1 commit into from Apr 29, 2020
Merged

home-assistant: 0.108.7 -> 0.109.0 #86326

merged 1 commit into from Apr 29, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 29, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin and dotlambda April 29, 2020 15:08
@Mic92 Mic92 requested a review from colemickens April 29, 2020 15:09
@colemickens
Copy link
Member

First impression: the systemd service is running, but my web ui is not accessible. Nothing is jumping out at first glance, I'll have to look into it more later.

@colemickens
Copy link
Member

btw, a bit off-topic, but related and people reading this might want the context: https://www.home-assistant.io/blog/2020/04/14/the-future-of-yaml/

It looks like this is going to impact some of my configuration in coming versions. I'd love to see a new lighter, declarative contender pop-up...

@colemickens
Copy link
Member

Hm. It came up eventually. That took a long time, even by HA standards.

@Mic92
Copy link
Member Author

Mic92 commented Apr 29, 2020

Works for me.

@Mic92 Mic92 merged commit 1330dcf into NixOS:master Apr 29, 2020
@Mic92 Mic92 deleted the home-assistant branch April 29, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@dotlambda dotlambda Awaiting requested review from dotlambda

@colemickens colemickens Awaiting requested review from colemickens

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @colemickens