Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staging: revert the binutils bump #86324

Merged
merged 4 commits into from Apr 29, 2020
Merged

staging: revert the binutils bump #86324

merged 4 commits into from Apr 29, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Apr 29, 2020

Motivation for this change

The binutils bump from 2.33.1 to 2.34 made it necessary to set ac_cv_func_lchmod=no for various binaries so they keep running (inside the nix sandbox at least).

This had to be done with coreutils in e30f1e3 as part of #85951, but it seems more userland needs fixes, like rsync. I manually verified setting ac_cv_func_lchmod=no rsync would fix that specific problem, but we don't know what other applications also need fixing, so let's revert this for now until we figured out why binutils causes this behaviour now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edolstra and Ericson2314 April 29, 2020 14:44
@flokli
Revert "libbfd: fix build"
237ef30 
This reverts commit 7550ab9.
@flokli
Copy link
Contributor Author

flokli commented Apr 29, 2020

Also reverted the now obsolete bump fixup from @Ma27 in #86260.

@lovesegfault
Copy link
Member

@flokli I would prefer if instead we just added ac_cv_func_lchmod=no to stdenv on Linux with glibc, as I think that's the only place it applies and should apply everywhere.

@flokli
Copy link
Contributor Author

flokli commented Apr 29, 2020 •
edited

If it's possible, this would still be the "big hammer" approach. I'd prefer to understand the problem better, and stick with old binutils for now, at least until we know where this needs to be fixed upstream.

@Ericson2314
Copy link
Member

I gotta ask, what is with the upstream maintainership of binutils? I've never been closely involved, but it seems like every version bump for us is nightmare. We can't be the only distro facing this.

@flokli
Copy link
Contributor Author

flokli commented Apr 29, 2020

I'll revert this for now to unbreak staging. If we can fix it, we can always add it back.

@flokli flokli merged commit 8882516 into NixOS:staging Apr 29, 2020
@flokli flokli deleted the staging-revert-binutils branch April 29, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@guibou guibou Awaiting requested review from guibou

@edolstra edolstra Awaiting requested review from edolstra

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @lovesegfault @Ericson2314