Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmuxinator: 1.1.4 -> 2.0.0 #86334

Merged
merged 2 commits into from May 1, 2020
Merged

tmuxinator: 1.1.4 -> 2.0.0 #86334

merged 2 commits into from May 1, 2020

Conversation

cust0dian-old
Copy link
Contributor

@cust0dian-old cust0dian-old commented Apr 29, 2020 •
edited

Motivation for this change

https://github.com/tmuxinator/tmuxinator/releases/tag/v1.1.5
https://github.com/tmuxinator/tmuxinator/releases/tag/v2.0.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor

marsam commented Apr 30, 2020

2.0.0 was released a few hours ago https://github.com/tmuxinator/tmuxinator/releases/tag/v2.0.0
Would you mind updating it?

@cust0dian-old cust0dian-old changed the title tmuxinator: 1.1.4 -> 1.1.5 tmuxinator: 1.1.4 -> 2.0.0 Apr 30, 2020
@cust0dian-old
Copy link
Contributor Author

@marsam sure, done!

@doronbehar
Copy link
Contributor

@cust0dian can you make sure the completion files are installed as well?

https://github.com/tmuxinator/tmuxinator/blob/master/README.md#completion

@cust0dian-old
Copy link
Contributor Author

cust0dian-old commented May 1, 2020 •
edited

@doronbehar sure, took a stab at it:

tree result/share/
result/share/
├── bash-completion
│   └── completions
│       └── tmuxinator.bash
├── fish
│   └── vendor_completions.d
│       └── tmuxinator.fish
└── zsh
    └── site-functions
        └── _tmuxinator

6 directories, 3 files

although would greatly appreciate if someone more experienced with Ruby packaging double-checked my approach. I left it as a separate commit for easier review, will squash it once it's greenlit.

cust0dian-old
cust0dian-old commented May 1, 2020
View reviewed changes
pkgs/tools/misc/tmuxinator/default.nix
nativeBuildInputs = [ installShellFiles ];

postInstall = ''
installShellCompletion $GEM_HOME/gems/${gemName}-${version}/completion/tmuxinator.{bash,zsh,fish}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure getting to gem source via $GEM_HOME/gems/${gemName}-${version}/ is the way to do it (decided to use this approach as I've seen it in other places)

@cust0dian-old
Copy link
Contributor Author

@GrahamcOfBorg eval

@Mic92
Copy link
Member

Mic92 commented May 1, 2020

Result of nixpkgs-review pr 86334 1

1 package built:
- tmuxinator

@Mic92 Mic92 merged commit d794222 into NixOS:master May 1, 2020
@cust0dian-old cust0dian-old deleted the tmuxinator-1.1.5 branch May 2, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cust0dian-old @marsam @doronbehar @Mic92 @cust0dian