Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixpkgs-fmt: fix erroneous debug output #86335

Merged
merged 1 commit into from May 2, 2020
Merged

nixpkgs-fmt: fix erroneous debug output #86335

merged 1 commit into from May 2, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Apr 29, 2020

Prior to this, when used in conjunction with e.g. format-all-mode,
garbage like

node: NODE_STRING@[8934; 9139), indent: IndentLevel { level: 3, alignment: 0 }

would be written to the file.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h cole-h requested a review from zimbatm April 29, 2020 16:26
@pbogdan
Copy link
Member

pbogdan commented Apr 29, 2020

While personally I reverted back to 0.7.0 perhaps it might be worth checking if upstream would be willing to cut a new release? Without this patch 0.8.0 was rendered pretty much unusable…

@cole-h
Copy link
Member Author

cole-h commented Apr 29, 2020 •
edited

Done here: nix-community/nixpkgs-fmt#201 (comment).

EDIT: Just realized you are the author of that issue... lol. Guess I didn't need to tell you. Force-pushed to add a note to the patch (in my haste, I forgot).

@cole-h
nixpkgs-fmt: fix erroneous debug output
7f6e97a 
Prior to this, when used in conjunction with e.g. `format-all-mode`,
garbage like

    node: NODE_STRING@[8934; 9139), indent: IndentLevel { level: 3, alignment: 0 }

would be written to the file.
@zimbatm
Copy link
Member

zimbatm commented Apr 29, 2020

sorry about the breaking changes. Another release is coming tomorrow with all the fixes.

@cole-h
Copy link
Member Author

cole-h commented Apr 29, 2020

All good. I'll leave this open until then (so people can stumble across it), if that works for you. Feel free to close this after the update :)

@grahamc
Copy link
Member

grahamc commented Apr 29, 2020

@ofborg eval

(testing a deploy)

@zimbatm
Copy link
Member

zimbatm commented Apr 30, 2020

we hit another issue which will probably be fixed tomorrow

@zimbatm
Copy link
Member

zimbatm commented May 2, 2020

looks like it's going to take longer

@zimbatm zimbatm merged commit 440110b into NixOS:master May 2, 2020
@cole-h cole-h deleted the nixpkgs-fmt branch May 2, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cole-h @pbogdan @zimbatm @grahamc