Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.snowpack: init at 2.0.3 #86371

Closed
wants to merge 2 commits into from

Conversation

chip4
Copy link

@chip4 chip4 commented Apr 30, 2020

Motivation for this change

Adds Snowpack. Snowpack is a command line utility like bower or npm to manage dependencies. It is meant to be installed globally, so it fits as a nodePackage package.

I followed the directions at https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/node.section.md which resulted in updating all the packages to the latest versions on npm. I made that a separate commit in case those changes aren't desired as part of adding this new package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@chip4 chip4 changed the title nodePackages.snowpack: init at 1.7.1 nodePackages.snowpack: init at 2.0.3 May 29, 2020
@chip4 chip4 closed this May 29, 2020
@chip4
Copy link
Author

chip4 commented May 29, 2020

version 2.0.3 of snowpack is failing to build with nix-build -A nodePackages.snowpack with an npm postinstall script error from esbuild@0.3.9:

Error: Command failed: npm install --silent --prefer-offline --no-audit --progress=false esbuild-linux-64@0.3.9

This wasn't happening with snowpack version 1.7.1, I'll have to debug this issue and put up another PR if/when I have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants