Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions.ms-vscode.cpptools: 0.27.0 -> 0.27.1 #86359

Merged
merged 1 commit into from May 2, 2020
Merged

vscode-extensions.ms-vscode.cpptools: 0.27.0 -> 0.27.1 #86359

merged 1 commit into from May 2, 2020

Conversation

firmero
Copy link
Contributor

@firmero firmero commented Apr 29, 2020

Motivation for this change

Previous version of package doesn't work. Complaining about missing cpptools binaries, probably cause by renaming binaries in 0.27.0 version.

Extension is now fetched from the Microsoft repository (instead of the marketplace). It also contains platform-specific binary dependencies. In the previous version they were fetched from the Microsoft website and additionally inserted to the final extension.

Package supports Linux, but there is probably a way no make it work on OSX.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@firmero
vscode-extensions.ms-vscode.cpptools: 0.27.0 -> 0.27.1
7e38363 
Extension is now fetched from the Microsoft repository (instead of the
marketplace). It also contains platform-specific binary dependencies. In the
previous version they were fetched from the Microsoft website and additionally
inserted to the final extension.

Package supports Linux, but there is probably a way no make it work on OSX.
@firmero firmero requested a review from jonringer as a code owner April 29, 2020 21:56
eadwu
eadwu approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine.

jonringer
jonringer approved these changes May 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build fine

@jonringer jonringer merged commit 5d24a59 into NixOS:master May 2, 2020
@firmero firmero deleted the cpptools-0.27.1 branch May 2, 2020 05:46
@firmero firmero restored the cpptools-0.27.1 branch May 2, 2020 05:46
@firmero firmero deleted the cpptools-0.27.1 branch May 2, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@eadwu eadwu eadwu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@firmero @jonringer @eadwu @Janik-Haag