Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.window-is-ready-remover: init at unstable-2020-03-25 #86361

Merged
merged 1 commit into from May 1, 2020
Merged

gnomeExtensions.window-is-ready-remover: init at unstable-2020-03-25 #86361

merged 1 commit into from May 1, 2020

Conversation

firmero
Copy link
Contributor

@firmero firmero commented Apr 29, 2020

Motivation for this change

Window Is Ready - Notification Remover.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 29, 2020
@firmero firmero force-pushed the gnomeExtensions.window-is-ready-remover-1.02 branch from c760d99 to 34f8fe6 Compare April 30, 2020 23:35
@firmero firmero changed the title gnomeExtensions.window-is-ready-remover: init at 1.02 gnomeExtensions.window-is-ready-remover: init at unstable-2020-03-25 Apr 30, 2020
@firmero firmero force-pushed the gnomeExtensions.window-is-ready-remover-1.02 branch from 34f8fe6 to e523407 Compare April 30, 2020 23:46
@jtojnar jtojnar merged commit c8420c5 into NixOS:master May 1, 2020
@jtojnar
Copy link
Contributor

jtojnar commented May 1, 2020

Thanks.

@firmero firmero deleted the gnomeExtensions.window-is-ready-remover-1.02 branch May 1, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@firmero @jtojnar