Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] skypeforlinux: 8.58.0.93 -> 8.59.0.77 #86354

Merged
merged 2 commits into from Apr 30, 2020

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Apr 29, 2020

Motivation for this change

Backport of #86256

Update to latest skype version.

In addition the university of chicago is added as an additional mirror to try to fetch
the binary from. This reduces the change of #81868 and #85724 happening again in the
future. This might also be a good candidate to backport to stable releases.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The university of chigaco keeps the binaries of old releases.

This reduces the change of NixOS#81868 and NixOS#85724 happening again in the
future.

(cherry picked from commit e4aab9c)
Copy link
Member

@jraygauthier jraygauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged.

Urls and sha same as the master version so still alright.

Tested build and execution of the app. Video stream still ok in settings and made a successfull test call.

Here's my (truncated) output:

$ gh pr checkout 86354
remote: Enumerating objects: 101, done.
remote: Counting objects: 100% (101/101), done.
remote: Total 216 (delta 101), reused 101 (delta 101), pack-reused 115
Receiving objects: 100% (216/216), 125.39 KiB | 7.84 MiB/s, done.
Resolving deltas: 100% (154/154), completed with 66 local objects.
From https://github.com/NixOS/nixpkgs
 * [new ref]                 refs/pull/86354/head -> 20.03-skypeforlinux
Switched to branch '20.03-skypeforlinux'


$ nix-shell -I nixpkgs=. -p skypeforlinux
these derivations will be built:
  /nix/store/mws1hz6j82kr4nfi2mbdfslh2yv9k3is-skypeforlinux-8.59.0.77.drv
these paths will be fetched (135.53 MiB download, 644.33 MiB unpacked):
# ..
building '/nix/store/mws1hz6j82kr4nfi2mbdfslh2yv9k3is-skypeforlinux-8.59.0.77.drv'...
patching sources
configuring
no configure script, doing nothing
building
no Makefile, doing nothing
glibPreInstallPhase
installing
'/nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77/usr/bin' -> '/nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77/bin'
'/nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77/usr/bin/skypeforlinux' -> '/nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77/bin/skypeforlinux'
# ..
'/nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77/usr/share/skypeforlinux/swiftshader/libvk_swiftshader.so' -> '/nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77/share/skypeforlinux/swiftshader/libvk_swiftshader.so'
glibPreFixupPhase
gappsWrapperArgsHook
post-installation fixup
Wrapping link: '/nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77/bin/skypeforlinux'
shrinking RPATHs of ELF executables and libraries in /nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77
# ..
shrinking /nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77/share/skypeforlinux/chrome-sandbox
rewriting symlink /nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77/bin/.skypeforlinux-wrapped to be relative to /nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77
strip is /nix/store/nyhj00w339gk2gaj3faz70gjrnbmam8v-binutils-2.31.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77/bin
patching script interpreter paths in /nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77
checking for references to /build/ in /nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77...
not an ELF executable
not an ELF executable
warning: working around a Linux kernel bug by creating a hole of 729088 bytes in ‘/nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77/share/skypeforlinux/skypeforlinux’
cannot find section .interp
# ..
cannot find section .interp

$ which skypeforlinux 
/nix/store/5h0z8bpyarvv5nkh4wbqi5040ksb4avw-skypeforlinux-8.59.0.77/bin/skypeforlinux

$ skypeforlinux 
Fontconfig warning: "/etc/fonts/fonts.conf", line 86: unknown element "blank"
(electron) 'setZoomLevel function' is deprecated and will be removed. Please use 'zoomLevel property' instead.
(electron) 'getZoomLevel function' is deprecated and will be removed. Please use 'zoomLevel property' instead.
(electron) 'setBadgeCount function' is deprecated and will be removed. Please use 'badgeCount property' instead.
ioctl failed for wlan0, errno = 19 (No such device)
ioctl failed for wlp2s0, errno = 19 (No such device)
ioctl failed for wlp3s0, errno = 19 (No such device)
^C^C

@talyz talyz merged commit 7b838df into NixOS:release-20.03 Apr 30, 2020
@talyz talyz deleted the 20.03-skypeforlinux branch April 30, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants