Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctrtool: 0.16 -> 0.7 and fix cross compiling #86310

Merged
merged 1 commit into from Nov 24, 2020
Merged

ctrtool: 0.16 -> 0.7 and fix cross compiling #86310

merged 1 commit into from Nov 24, 2020

Conversation

marius851000
Copy link
Contributor

Motivation for this change

update for ctrtool are avalaible

Things done

I previously used the 0.16 version, but that was the makerom version, which is hosted on the same repository. I additionnally fixed cross compiling for a number of platform -- including windows.
Checked that it can still read info from a 3ds game too.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUING.md.

@FRidh
Copy link
Member

FRidh commented May 1, 2020

please check the contribution guidelines for the naming of commits

@marius851000
Copy link
Contributor Author

You're right, sorry (made a long time I haven't updated anything, will change that)

@marius851000 marius851000 changed the title ctrtool: "update" to 0.7 and fix cross compiling ctrtool: 0.16 -> 0.7 and fix cross compiling Jun 18, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/198

@ryantm
Copy link
Member

ryantm commented Nov 24, 2020

Result of nixpkgs-review pr 86310 1

1 package built:
  • ctrtool

@ryantm ryantm merged commit 28ee64c into NixOS:master Nov 24, 2020
@ryantm
Copy link
Member

ryantm commented Nov 24, 2020

@marius851000 Thanks. Looks like the project owner changed their GitHub name, so you might want to update that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marius851000 @FRidh @nixos-discourse @ryantm