Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_3mux: 0.2.0 -> 1.0.1 #86309

Closed
wants to merge 3 commits into from
Closed

_3mux: 0.2.0 -> 1.0.1 #86309

wants to merge 3 commits into from

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Apr 29, 2020 •
edited

Motivation for this change

https://github.com/aaronjanse/3mux/releases/tag/v1.0.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from aaronjanse and kalbasit April 29, 2020 10:52
@aaronjanse
Copy link
Member

aaronjanse commented Apr 29, 2020 •
edited

What's the best way to remove the fuzz binary from $OUT/bin? Maybe a simple post-install rm command? EDIT: see below

@aaronjanse
Copy link
Member

Would you mind adding the following, based on the way gotools removes an unneeded module?

  postPatch = ''
    rm -rf fuzz
  '';

@Mic92
Copy link
Member

Mic92 commented Apr 30, 2020

Result of nixpkgs-review pr 86309 1

1 package built:
- _3mux

@Br1ght0ne
Copy link
Member Author

@Mic92 I read through #88258, but I have a question about vendorSha256: is the actual SHA-256 exactly the same as modSha256 (e.g. it's only a rename), or is it generated differently?

@Mic92
Copy link
Member

Mic92 commented May 24, 2020

@Mic92 I read through #88258, but I have a question about vendorSha256: is the actual SHA-256 exactly the same as modSha256 (e.g. it's only a rename), or is it generated differently?

It is generated differently hence the rename.

@Br1ght0ne @Mic92
_3mux: 0.2.0 -> 1.0.1
98a6047 
Squashed commits:
- _3mux: 0.2.0 -> 0.3.0
- _3mux: remove fuzz in postPatch
- _3mux: replace postPatch with exludedPackages
- _3mux: 0.3.0 -> 1.0.1

Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
@Br1ght0ne Br1ght0ne changed the title _3mux: 0.2.0 -> 0.3.0 _3mux: 0.2.0 -> 1.0.1 May 26, 2020
@Br1ght0ne Br1ght0ne requested a review from Mic92 May 26, 2020 19:58
@Br1ght0ne

This comment has been minimized.

Sign in to view
@ofborg ofborg bot requested a review from aaronjanse May 26, 2020 22:29
@aaronjanse
Copy link
Member

I think I figured it out: 3mux cross-compiles to darwin if CGO_ENABLED = 1

@Br1ght0ne
_3mux: set CGO_ENABLED=1 for linux -> darwin cross compilation
f0a9329 
Suggested-by: Aaron Janse <aaronjanse@users.noreply.github.com>
@aaronjanse
Copy link
Member

I don't have a darwin setup to test this on, but other than that, this LGTM

aaronjanse
aaronjanse suggested changes May 26, 2020
View reviewed changes
Copy link
Member

@aaronjanse aaronjanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait. I think CGO_ENABLED should be enabled for all OSes?

@ofborg ofborg bot requested a review from aaronjanse May 26, 2020 23:07
@Mic92
Copy link
Member

Mic92 commented May 27, 2020

@GrahamcOfBorg build _3mux

Mic92
Mic92 reviewed May 28, 2020
View reviewed changes
pkgs/tools/misc/3mux/default.nix

meta = with stdenv.lib; {
description = "Terminal multiplexer inspired by i3";
homepage = "https://github.com/aaronjanse/3mux";
license = licenses.mit;
maintainers = with maintainers; [ aaronjanse filalex77 ];
# TODO: fix modules build on darwin
broken = stdenv.isDarwin;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is still broken on macOS itself.

bhipple
bhipple requested changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing

@Lassulus
Copy link
Member

meanwhile: this was bumped to 0.3.0

@aaronjanse
Copy link
Member

See #116272 for an update to v1.1.0. Thank you @Br1ght0ne!

@Br1ght0ne Br1ght0ne closed this Mar 14, 2021
@Br1ght0ne Br1ght0ne deleted the 3mux-0.3.0 branch March 14, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@bhipple bhipple bhipple requested changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@aaronjanse aaronjanse Awaiting requested review from aaronjanse

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Br1ght0ne @aaronjanse @Mic92 @Lassulus @bhipple @ryantm