Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve robustness of various Rust packages #82982

Merged
merged 10 commits into from Apr 30, 2020
Merged

improve robustness of various Rust packages #82982

merged 10 commits into from Apr 30, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Mar 20, 2020 •
edited

Motivation for this change

Some cleanup in preparation for #82342.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 I cherry-picked your librustzcash fix and reworded the commit message to slightly decouple it from #82342.

I built and ran all of these packages by running {binary} --help. They all displayed their help flags at least (except for cfdyndns, which panicked without some env vars set).

@bhipple A few of the packages that showed up in git grep target/release actually need it (or, at least, don't benefit from it being changed to $releaseDir). Just figured I'd let you know why I left out ycmd and vdirsyncer.

@cole-h cole-h mentioned this pull request Mar 20, 2020
Merged
10 tasks
@cole-h cole-h changed the title improve robustness of installPhase of various Rust packages improve robustness of various Rust packages Mar 20, 2020
@Ma27 Ma27 requested a review from bhipple March 26, 2020 13:15
@cole-h
Copy link
Member Author

cole-h commented Mar 26, 2020

I accidentally removed the man output from gitAndTools.git-ignore. Re-added in this force-push.

@cole-h
Copy link
Member Author

cole-h commented Apr 29, 2020

@ofborg build ripgrep zcash lsd

(Testing recent ofborg deploy.)

@Ma27 Ma27 merged commit ee58c7a into NixOS:master Apr 30, 2020
@Ma27
Copy link
Member

Ma27 commented Apr 30, 2020

Thanks for taking care of this! Did some local tests and your changes seem fine now 👍

@cole-h cole-h deleted the rust-cleanup branch April 30, 2020 00:09
@cole-h cole-h mentioned this pull request May 4, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@bhipple bhipple Awaiting requested review from bhipple

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cole-h @Ma27 @alyssais