helmsman: init at 3.3.0 #86328
Merged
helmsman: init at 3.3.0 #86328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxzi
suggested changes
Apr 29, 2020
jonringer
reviewed
May 12, 2020
Comment on lines
16
to
21
| meta = { | ||
| description = "Helm Charts (k8s applications) as Code tool"; | ||
| homepage = "https://github.com/Praqma/helmsman"; | ||
| license = lib.licenses.mit; | ||
| maintainers = with lib.maintainers; [ lynty ]; | ||
| platforms = lib.platforms.unix; |
There was a problem hiding this comment.
just to make it a little more concise
Suggested change
| meta = { | |
| description = "Helm Charts (k8s applications) as Code tool"; | |
| homepage = "https://github.com/Praqma/helmsman"; | |
| license = lib.licenses.mit; | |
| maintainers = with lib.maintainers; [ lynty ]; | |
| platforms = lib.platforms.unix; | |
| meta = with lib; { | |
| description = "Helm Charts (k8s applications) as Code tool"; | |
| homepage = "https://github.com/Praqma/helmsman"; | |
| license = licenses.mit; | |
| maintainers = with maintainers; [ lynty ]; | |
| platforms = platforms.unix; |
|
@Lynty thanks again for opening your first PR. PR volume is super high, and hard to get to everyone |
added 2 commits
May 12, 2020 13:47
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds https://github.com/Praqma/helmsman, a useful tool which allows you to automate the deployment/management of your Helm charts from version controlled code.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)