Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmux: 3.1 -> 3.1a #86357

Closed
wants to merge 1 commit into from
Closed

tmux: 3.1 -> 3.1a #86357

wants to merge 1 commit into from

Conversation

kimat
Copy link
Contributor

@kimat kimat commented Apr 29, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fpletz April 29, 2020 21:17
@iblech
Copy link
Contributor

iblech commented Apr 29, 2020

(Just a random passerby speaking.) I just tested the new package and confirm it works on Linux/NixOS. Thank you for your quick pull request!

For others, version 3.1a fixes this regression regarding integration with iTerm2.

@mweinelt
Copy link
Member

Duplicate of #86351.

@kimat kimat closed this Apr 29, 2020
@kimat kimat deleted the kimat-tmux-3.1a branch April 29, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kimat @iblech @mweinelt