Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP maintainer team #86342

Merged
merged 6 commits into from Apr 29, 2020
Merged

PHP maintainer team #86342

merged 6 commits into from Apr 29, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Apr 29, 2020 •
edited

#85575

But rebased on master. All approvals we need are already on the other one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu requested a review from edolstra as a code owner April 29, 2020 18:23
@etu etu merged commit f7a07e7 into NixOS:master Apr 29, 2020
@etu etu deleted the php-maintainer-team branch April 29, 2020 18:27
@ofborg ofborg bot requested review from Ma27, talyz, globin and aanderse April 29, 2020 18:31
@worldofpeace
Copy link
Contributor

Created a @NixOS/php team for yall.

@etu etu mentioned this pull request May 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@Ma27 Ma27 Awaiting requested review from Ma27 Ma27 is a code owner

@talyz talyz Awaiting requested review from talyz talyz is a code owner

@globin globin Awaiting requested review from globin globin is a code owner

@aanderse aanderse Awaiting requested review from aanderse aanderse is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: policy discussion 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @worldofpeace