Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liberation_ttf_v2: 2.00.4 -> 2.1.0 #86343

Merged
merged 1 commit into from Apr 30, 2020
Merged

liberation_ttf_v2: 2.00.4 -> 2.1.0 #86343

merged 1 commit into from Apr 30, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 29, 2020 •
edited

Motivation for this change

Version update.

Github is showing bigger diff than necessary, because I renamed pkgs/data/fonts/redhat-liberation-fonts/default.nix to pkgs/data/fonts/liberation-fonts/default.nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak mentioned this pull request Apr 29, 2020
Closed
10 tasks
@cole-h
Copy link
Member

cole-h commented Apr 30, 2020

@ofborg eval

Seems bot had a hiccup. Sorry!

@ofborg ofborg bot requested a review from 7c6f434c April 30, 2020 01:23
7c6f434c
7c6f434c approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update looks fine, not merging immediately because rebuild report from ofborg looks strange

@7c6f434c
Copy link
Member

@ofborg eval

@ofborg ofborg bot requested a review from 7c6f434c April 30, 2020 08:52
@7c6f434c
Copy link
Member

@grahamc Any idea why, say, cvc4 is shown as rebuilt? Doesn't depend on either version of Liberation fonts on my system from master (and hopefully it shouldn't…)

It is true that OpenJDK and LibreOffice do depend on fonts at the build time.

@7c6f434c
Copy link
Member

@prusnak maybe retarget this to staging?

@prusnak prusnak changed the base branch from master to staging April 30, 2020 15:58
@prusnak
Copy link
Member Author

prusnak commented Apr 30, 2020

retargeted

@7c6f434c 7c6f434c merged commit 06aa21f into NixOS:staging Apr 30, 2020
@prusnak prusnak deleted the liberation-fonts branch May 1, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @cole-h @7c6f434c