Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

st: 0.8.2 -> 0.8.3 #86336

Merged
merged 1 commit into from Apr 29, 2020
Merged

st: 0.8.2 -> 0.8.3 #86336

merged 1 commit into from Apr 29, 2020

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Apr 29, 2020

Motivation for this change

Update st to its latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
Copy link
Member

cole-h commented Apr 29, 2020

@ofborg eval

Bot got lost, sorry.

@talyz
Copy link
Contributor

talyz commented Apr 29, 2020

Thank you for submitting this! The file hash needs to be updated too, otherwise it still points to the old version of st.

@oxzi
Copy link
Member Author

oxzi commented Apr 29, 2020

@talyz: argh, of course. I was a little off track.

@Mic92
Copy link
Member

Mic92 commented Apr 29, 2020

Result of nixpkgs-review pr 86336 1

1 package built:
- st

@Mic92 Mic92 merged commit 9e34c3a into NixOS:master Apr 29, 2020
@oxzi oxzi deleted the st-0.8.3 branch April 29, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxzi @cole-h @talyz @Mic92