Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint: 1.25.0 -> 1.25.1 #86337

Merged
merged 1 commit into from Apr 29, 2020
Merged

golangci-lint: 1.25.0 -> 1.25.1 #86337

merged 1 commit into from Apr 29, 2020

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Apr 29, 2020

Motivation for this change

Update golangci-lint to its latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from manveru, anpryl and kalbasit April 29, 2020 16:44
@Mic92 Mic92 merged commit cde13a5 into NixOS:master Apr 29, 2020
@Mic92
Copy link
Member

Mic92 commented Apr 29, 2020

Result of nixpkgs-review pr 86337 1

2 packages built:
- golangci-lint
- vimPlugins.vim-go

@oxzi oxzi deleted the golangci-lint-v1.25.1 branch April 29, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru Awaiting requested review from manveru

@anpryl anpryl Awaiting requested review from anpryl

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxzi @Mic92