Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.rtl8821cu: init at 2020-05-16 #89484

Merged
merged 1 commit into from Aug 22, 2020
Merged

linuxPackages.rtl8821cu: init at 2020-05-16 #89484

merged 1 commit into from Aug 22, 2020

Conversation

contrun
Copy link
Contributor

@contrun contrun commented Jun 4, 2020

Motivation for this change

Add driver for realtek 8821cu/8811cu devices

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lassulus
Copy link
Member

hey, sorry for the delay.
rebasing is preferred over merge commits. could you maybe rebase your changes and remove the merge commit?

@contrun
Copy link
Contributor Author

contrun commented Aug 22, 2020

@Lassulus Done

@Lassulus Lassulus merged commit 7f2f02e into NixOS:master Aug 22, 2020
@contrun contrun deleted the rtl8821cu branch August 22, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@contrun @Lassulus