Had to open
nomad-software/vend#9 so that vend wouldn't run go mod tidy which isn't deterministic.

What I am a bit worried about is that new versions of vend might include new files. For that reason might not want to include it for all packages.

Vend rejected my patch, so we're going to have to maintain a semi permanent fork of it anyway :( Everything else is updated.

@Mic92 Fixed formatting :)

@Mic92 - I think nothing else is outstanding here.

IMHO useVend could be slightly more fitting, so we could describe it as: "Whether to use vend instead of go mod vendor to vendorize the go module dependencies".
But I don't have a strong opinion about it.

gobetween can be dropped from this PR. #93972

gobetween is dropped - working on figuring out hugo (looks like a rebase broke it).

And hugo is fixed - should be g2g

go-ethereum builds but the vendorSha256 needs to be updated.

diff --git a/pkgs/applications/blockchains/go-ethereum.nix b/pkgs/applications/blockchains/go-ethereum.nix
index e2b308d88e2..0edeccf4003 100644
--- a/pkgs/applications/blockchains/go-ethereum.nix
+++ b/pkgs/applications/blockchains/go-ethereum.nix
@@ -12,7 +12,7 @@ buildGoModule rec {
   };
 
   runVend = true;
-  vendorSha256 = "0r08fayxpccjyr29g38wc0zvpqgma9inyvdwcama1fyiq0n8n39d";
+  vendorSha256 = "1744df059bjksvih4653nnvb4kb1xvzdhypd0nnz36m1wrihqssv";
 
   subPackages = [
     "cmd/abidump"

Can you push the changes in nomad-software/vend@24fdebf to nomad-software/vend#10 please?

Upstream seems to be responsive so I'll give them a day or two to comment on the new changes.

Updated go-ethereum.

Re: vend - somehow I updated the pr verbally but didn't push. I'd strongly prefer we don't block on vend upstream, since they're still not convinced that the PR is needed + they've literally rejected every PR I sent them related to nix functionality. If they do merge it I can flip the repos back, but it's not great odds.

Re: vend - somehow I updated the pr verbally but didn't push. I'd strongly prefer we don't block on vend upstream, since they're still not convinced that the PR is needed + they've literally rejected every PR I sent them related to nix functionality. If they do merge it I can flip the repos back, but it's not great odds.

If they are willing to accept the functionality but request changes we may need to update packages vendorSha256 again?

Re: vend - somehow I updated the pr verbally but didn't push. I'd strongly prefer we don't block on vend upstream, since they're still not convinced that the PR is needed + they've literally rejected every PR I sent them related to nix functionality. If they do merge it I can flip the repos back, but it's not great odds.

If they are willing to accept the functionality but request changes we may need to update packages vendorSha256 again?

I wonder if we just should maintain our own fork anyway. The package is quite simple and we cannot have upstream breaking our hashes if @r-ryantm makes a PR and somebody merges it without knowing the consequences. It could be simplified a lot i.e. removing some dependencies like command-line coloring which is not showed in many cases anyway. @c00w what do you think about a fork maintained in https://github.com/nix-community?

@zowoq @Mic92 In what proves my prothetic abilities - they just rejected the PR :P

I can move this to nix-community (although I'd prefer if I could get admin permissions there on the vend repo).

@Mic92 Is this okay to merge or do you want to do the switch to nix-community in this PR?

@zowoq @Mic92 In what proves my prothetic abilities - they just rejected the PR :P

I can move this to nix-community (although I'd prefer if I could get admin permissions there on the vend repo).

I sent you an invite to the organisation. Once you moved the project their, you will be the maintainer and marked as such. However it also allows to easily move over maintenance in case you are lacking time.

@Mic92 Is this okay to merge or do you want to do the switch to nix-community in this PR?

Let's just move before. The process is just a few clicks away.

Checking darwin:

@ofborg build aerc blockbook go-ethereum hugo mautrix-whatsapp saml2aws