Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "treewide: replace base64 encoded hashes" #89520

Closed
wants to merge 1 commit into from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jun 5, 2020

This reverts commit 7b3a296.

Motivation for this change

The original change breaks node2nix updates #89423 (comment)
To properly get rid of base64 would require additional work to be done on node2nix side.

Things done
  • Tested to eval with Nix 2.0:
nix-shell -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/48d9754d2b110ea4b5e7248b74eec52befcd136c.tar.gz -p nix --pure --run "nix-build --version && nix-build . -A lingot.src"

@veprbl
Copy link
Member Author

veprbl commented Jun 8, 2020

Effectively reverted in #89649

@veprbl veprbl closed this Jun 8, 2020
@veprbl veprbl deleted the pr/revert_89423 branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant