Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: add various plugins #89491

Merged
merged 9 commits into from Jun 4, 2020
Merged

Conversation

davidtwco
Copy link
Member

Motivation for this change

This commit adds a handful of new Vim plugins - vim-hocon, vim-spirv, vim-hybrid, vim-tmux-clipboard, vim-numbertoggle, is-vim, and vim-mundo. In addition, it also updates existing Vim plugins, as that's what update.py always does.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's unlikely that the git history for coc-rust-analyzer will cause an issue.

Comment on lines 607 to +613
pname = "coc-rust-analyzer";
version = "2020-05-27";
version = "2020-06-04";
src = fetchFromGitHub {
owner = "fannheyward";
repo = "coc-rust-analyzer";
rev = "95fe45bb82f88a5da5461a2925c7daac1ff24155";
sha256 = "1zczdz07fmcd7i05bz99m3a90v1dnbf4mjbh1iha0h2kyj0fj0sd";
rev = "acd5e7fca38dbc8ad8bfe9f187f1f4e6ee64ea88";
sha256 = "14qyszmyzykibdkdv38cypc8gmhaz0301prirjbpf2gijryk922b";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a slight error with some of the git history with this bump, the rev and sha256 are updated in the spirv addition.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 89491 1

48 packages built:
- vimPlugins.NrrwRgn
- vimPlugins.ayu-vim
- vimPlugins.caw-vim
- vimPlugins.coc-fzf
- vimPlugins.coc-nvim
- vimPlugins.command-t
- vimPlugins.csv-vim
- vimPlugins.defx-nvim
- vimPlugins.denite-nvim
- vimPlugins.deoplete-fish
- vimPlugins.deoplete-khard
- vimPlugins.deoplete-lsp
- vimPlugins.deoplete-nvim
- vimPlugins.editorconfig-vim
- vimPlugins.fzf-vim
- vimPlugins.gentoo-syntax
- vimPlugins.indentLine
- vimPlugins.is-vim
- vimPlugins.lh-brackets
- vimPlugins.lh-vim-lib
- vimPlugins.neoterm
- vimPlugins.nerdtree
- vimPlugins.nvim-lsp
- vimPlugins.tagbar
- vimPlugins.vim-airline
- vimPlugins.vim-autoformat
- vimPlugins.vim-bazel
- vimPlugins.vim-codefmt
- vimPlugins.vim-devicons
- vimPlugins.vim-fugitive
- vimPlugins.vim-ghost
- vimPlugins.vim-gitgutter
- vimPlugins.vim-go
- vimPlugins.vim-hocon
- vimPlugins.vim-hybrid
- vimPlugins.vim-lsc
- vimPlugins.vim-maktaba
- vimPlugins.vim-mundo
- vimPlugins.vim-numbertoggle
- vimPlugins.vim-plug
- vimPlugins.vim-polyglot
- vimPlugins.vim-ps1
- vimPlugins.vim-snippets
- vimPlugins.vim-spirv
- vimPlugins.vim-test
- vimPlugins.vim-tmux-clipboard
- vimPlugins.vim-visual-multi
- vimPlugins.vimtex

@jonringer jonringer merged commit f37b4a8 into NixOS:master Jun 4, 2020
@davidtwco davidtwco deleted the vim-various-init branch June 14, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants