Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace SRI hashes (20.03) #89490

Closed
wants to merge 2 commits into from
Closed

replace SRI hashes (20.03) #89490

wants to merge 2 commits into from
+3,167 −3,167

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jun 4, 2020

Motivation for this change

These break compatibility with nix 2.0, see #89275. Unless we also want to backport #89476 to the 20.03 release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@LnL7 LnL7 requested review from FRidh and jonringer as code owners June 4, 2020 16:56
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 4, 2020
@LnL7 LnL7 force-pushed the replace-sri-hashes branch from 3841200 to 18773e2 Compare June 5, 2020 16:09
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Jun 5, 2020
vcunat
vcunat approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 20.03 (and older) I really prefer this instead of the requirement bump.

@worldofpeace
Copy link
Contributor

@LnL7 Rebase? This LGTM.

@LnL7 LnL7 force-pushed the replace-sri-hashes branch from 18773e2 to cf3dc63 Compare June 18, 2020 16:47
LnL7 added 2 commits June 18, 2020 18:54
@LnL7
treewide: replace SRI hashes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
63ce676
@LnL7
poetry2nix: translate hashes to sha256

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: A0E01EF44C27BF00
Learn about vigilant mode
64223c8 
(cherry picked from commit 8d705d9)
@LnL7 LnL7 force-pushed the replace-sri-hashes branch from cf3dc63 to 64223c8 Compare June 18, 2020 16:54
@ofborg ofborg bot added 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 18, 2020
@ryantm ryantm added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 3, 2020
@bhipple
Copy link
Contributor

bhipple commented Oct 30, 2020

Has merge conflict and 20.03 is no longer maintained, so I'll close. Feel free to re-open if you still want to do this of course.

@bhipple bhipple closed this Oct 30, 2020
@worldofpeace
Copy link
Contributor

20.03 is still maintained #101975 and accepting fixes. I hope people don't close PRs thinking this, though, for this particular one it was good to close regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

@bhipple bhipple

@FRidh FRidh

@jonringer jonringer

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LnL7 @worldofpeace @bhipple @vcunat @ryantm