Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs related to search on the index page #437

Merged
merged 2 commits into from Jun 3, 2020

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Jun 3, 2020

Options search simply doesn't work, it goes to the packages search.

Packages search doesn't work because it tries to use nixos-undefined as a channel. Look at the commit for more information why.

Fixes #436

First of all, there is a bug in that `latest-nixos-series` has never
been added to the body, so it ends up using the
`channel=nixos-undefined` parameter.

Then, the packages search *already* knows what to do when no channel is
given, let's reduce complexity and simply send a query.
Choosing on the text node of an element is a fool's errand. By using a
class here we are free to reword the options without breaking the
functionality.
@samueldr samueldr requested a review from garbas June 3, 2020 23:26
@garbas
Copy link
Member

garbas commented Jun 3, 2020

Tnx for fixing my screw-ups

@garbas garbas merged commit 688b0e4 into NixOS:master Jun 3, 2020
@samueldr samueldr deleted the fix/index-search-bug branch June 3, 2020 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking the search option "... for options" leads to packages
2 participants