Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Origin isolation: refactor and deduplicate web platform tests #23964

Merged
merged 1 commit into from Jun 17, 2020
Merged

Origin isolation: refactor and deduplicate web platform tests #23964

merged 1 commit into from Jun 17, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 3, 2020 •
edited

Now that I've written a bunch of them, I'm confident in building some
abstractions to deduplicate the testing code.

This additionally adds jsdoc documentation for all of the exported
functions in helpers.mjs.

Bug: 1042415
Change-Id: I3e2220708f4d5afff5a815de876971db3f689826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229435
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777962}

wpt-pr-bot
wpt-pr-bot approved these changes Jun 3, 2020
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@domenic @chromium-wpt-export-bot
Origin isolation: refactor and deduplicate web platform tests
f3d4e8d 
Now that I've written a bunch of them, I'm confident in building some
abstractions to deduplicate the testing code.

This additionally adds jsdoc documentation for all of the exported
functions in helpers.mjs.

Bug: 1042415
Change-Id: I3e2220708f4d5afff5a815de876971db3f689826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229435
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777962}
@stephenmcgruer
Copy link
Contributor

Fails chrome-dev stability check:

 2:38.66 INFO ## Unstable results ##
 2:38.67 INFO |                         Test                        |                                Subtest                                |            Results            |                                        Messages                                        |
 2:38.67 INFO |-----------------------------------------------------|-----------------------------------------------------------------------|-------------------------------|----------------------------------------------------------------------------------------|
 2:38.67 INFO | `/origin-isolation/removing-iframes.sub.https.html` |                                                                       | **ERROR: 5/10, OK: 5/10**     |                                                                                        |
 2:38.67 INFO | `/origin-isolation/removing-iframes.sub.https.html` | `Before: messageerror event must occur`                               | **PASS: 5/10, MISSING: 5/10** |                                                                                        |
 2:38.67 INFO | `/origin-isolation/removing-iframes.sub.https.html` | `Before: setting document.domain must not give sync access`           | **PASS: 5/10, MISSING: 5/10** |                                                                                        |
 2:38.67 INFO | `/origin-isolation/removing-iframes.sub.https.html` | `Remove the iframe and insert new ones`                               | **PASS: 5/10, MISSING: 5/10** |                                                                                        |
 2:38.67 INFO | `/origin-isolation/removing-iframes.sub.https.html` | `Parent to child2: messageerror event must occur`                     | **PASS: 5/10, MISSING: 5/10** |                                                                                        |
 2:38.67 INFO | `/origin-isolation/removing-iframes.sub.https.html` | `Parent to child2: setting document.domain must not give sync access` | **PASS: 5/10, MISSING: 5/10** |                                                                                        |
 2:38.67 INFO | `/origin-isolation/removing-iframes.sub.https.html` | `Parent to child3: messageerror event must occur`                     | **PASS: 5/10, MISSING: 5/10** |                                                                                        |
 2:38.67 INFO | `/origin-isolation/removing-iframes.sub.https.html` | `Parent to child3: setting document.domain must not give sync access` | **PASS: 5/10, MISSING: 5/10** |                                                                                        |
 2:38.67 INFO | `/origin-isolation/removing-iframes.sub.https.html` | `child2 to child3: message event must occur`                          | **FAIL: 5/10, MISSING: 5/10** | `assert_equals: expected "WebAssembly.Module message received" but got "messageerror"` |
 2:38.67 INFO | `/origin-isolation/removing-iframes.sub.https.html` | `child2 to child3: setting document.domain must give sync access`     | **FAIL: 5/10, MISSING: 5/10** | `assert_equals: expected "accessed document successfully" but got "SecurityError"`     |
 2:38.67 INFO | `/origin-isolation/removing-iframes.sub.https.html` | `child3 to child2: message event must occur`                          | **FAIL: 5/10, MISSING: 5/10** | `assert_equals: expected "WebAssembly.Module message received" but got "messageerror"` |
 2:38.67 INFO | `/origin-isolation/removing-iframes.sub.https.html` | `child3 to child2: setting document.domain must give sync access`     | **FAIL: 5/10, MISSING: 5/10** | `assert_equals: expected "accessed document successfully" but got "SecurityError"`     |
 2:38.67 INFO

I'm unable to reproduce locally (via ./wpt run --log-mach-level=info --log-mach=- --verify --verify-log-full --channel=experimental chrome origin-isolation/removing-iframes.sub.https.html) either with or without this PR, so admin-merging. cc @domenic as an FYI

@stephenmcgruer stephenmcgruer merged commit 3720a98 into master Jun 17, 2020
@stephenmcgruer stephenmcgruer deleted the chromium-export-cl-2229435 branch June 17, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
chromium-export origin-isolation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chromium-wpt-export-bot @stephenmcgruer @wpt-pr-bot @domenic