De-flake some pointerevents wpt tests - Part 3 #23965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 3, 2020
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2203144
branch
2 times, most recently
from
b56fced
to
05580f7
Compare
Because of Linux memory leak, pointerevent wpt tests pointerevent_boundary_events_at_implicit_release_hoverable_pointers.html pointerevent_releasepointercapture_onpointerup_mouse.html and pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked .html are flaky, we should finish the test in the actions promise's callback to guarantee the actions are all executed before the test finishes to avoid memory leak. Bug: 998948, 1025944 Change-Id: I1ba6cbd8029a6093eefc29c287af86c80cb45ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203144 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#777464}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2203144
branch
from
05580f7
to
9da985a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of Linux memory leak, pointerevent wpt tests
pointerevent_boundary_events_at_implicit_release_hoverable_pointers.html
pointerevent_releasepointercapture_onpointerup_mouse.html and
pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked
.html are flaky, we should finish the test in the actions promise's
callback to guarantee the actions are all executed before the test
finishes to avoid memory leak.
Bug: 998948, 1025944
Change-Id: I1ba6cbd8029a6093eefc29c287af86c80cb45ffe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203144
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777464}