Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newtonwars: symlink nw to newtonwars #89446

Closed
wants to merge 1 commit into from
Closed

newtonwars: symlink nw to newtonwars #89446

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 3, 2020

Motivation for this change

newtonwars: binary name differs from package name #89377

Things done
ln -s $out/bin/nw $out/bin/newtonwars
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from pSub June 3, 2020 22:10
NickHu
NickHu approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@NickHu NickHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. This looks innocuous enough, but I just wanted to point out that it seems like the binary is deliberately called nw, and e.g. in the Arch PKGBUILD this symlink doesn't get made.

I'll leave it open for a day or two to give people a chance to raise concerns, but otherwise I'll merge it after.

@marsam
Copy link
Contributor

marsam commented Jun 5, 2020

I disagree, upstream uses nw as the executable name, we shouldn't deviate from it.

@OPNA2608
Copy link
Contributor

OPNA2608 commented Jun 5, 2020

I agree with @marsam, this seems like something you should approach the upstream repo over instead. It's a deliberate choice by them to compile it as nw and only that, not an installation bug with our build expression.

@Mic92 Mic92 closed this Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @OPNA2608 @NickHu @Mic92