Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godot-server, godot-headless: init at 3.2.2 #89511

Merged
merged 3 commits into from Aug 22, 2020
Merged

Conversation

yusdacra
Copy link
Member

@yusdacra yusdacra commented Jun 4, 2020

Motivation for this change

Add godot-server for running dedicated game servers and godot-headless to export projects in an automated manner.
https://docs.godotengine.org/en/stable/development/compiling/compiling_for_x11.html#compiling-a-headless-server-build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lassulus
Copy link
Member

hmm, I'm not a big fan of doing this in all-packages.nix. Maybe you could add new files for that?
also sorry for the delay

@yusdacra
Copy link
Member Author

hmm, I'm not a big fan of doing this in all-packages.nix. Maybe you could add new files for that?
also sorry for the delay

Should be done now, added files in development/tools/godot. No problem by the way.

Comment on lines 1 to 2
{ pkgs, stdenv }:
pkgs.godot.overrideAttrs (oldAttrs: rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ pkgs, stdenv }:
pkgs.godot.overrideAttrs (oldAttrs: rec {
{ godot, stdenv }:
godot.overrideAttrs (oldAttrs: rec {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@yusdacra yusdacra changed the title godot-server, godot-headless: init at 3.2.1 godot-server, godot-headless: init at 3.2.2 Aug 22, 2020
@Lassulus Lassulus merged commit 4cfd81a into NixOS:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants