nixos/buildbot-master: fix typo in services.buildbot-master.bpPort #89510
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: nixos
|
@ofborg test buildbot |
lopsided98
suggested changes
Jun 4, 2020
nixos/modules/services/continuous-integration/buildbot/master.nix
Outdated
Show resolved
Hide resolved
It's pbPort, and it's also a connection string, meaning listen-on-localhost is also possible. Provide an alias for the old option name, so old configs still work.
|
@ofborg test buildbot |
lopsided98
approved these changes
Jun 4, 2020
makefu
approved these changes
Jun 4, 2020
|
Yeah, I edited the buildbot vm test to ensure setting both |
|
@flokli thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's pbPort, and it's also a connection string, meaning
listen-on-localhost is also possible. Provide an alias for the old
option name, so old configs still work.
Motivation for this change
Having to write typos on purpose in the config is annoying, also only listening on localhost if the worker is on the same machine is nice.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)